Add more ways to collect Nav Areas #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CNavArea.GetAdjacent/IncomingConnectionLength
Kenzzer
requested changes
Aug 1, 2023
There was a problem hiding this comment.
It's too late to correct the existence of SurroundingAreasCollector but we could simply extend it through a methodmap like so methodmap AreasCollector < SurroundingAreasCollector, we avoid the creation of new natives, while staying bcompat.
Good PR, and good natives addition otherwise.
Kenzzer
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several new ways to collect areas in the navigation mesh.
CollectAreasOverlappingExtentandCollectAreasInRadiusnatives toCNavMesh. Their equivalents in VScript areNavMesh.GetNavAreasOverlappingEntityExtent(but less restrictive) andNavMesh.GetNavAreasInRadius, respectively.CollectAreasAlongLine, which as the name states, starts at an area and collects areas along the mesh towards the ending area in a straight line.BuildPathas it doesn't do any path making whatsoever.GetAdjacentLengthandGetIncomingConnectionLengthtoCNavArea, which returns the length of the connection between the areas' centers. This is a cached value.GetVectorDistance, etc).GetIncomingConnection's C++ native function.With the new collection methods, I'm not sure if
SurroundingAreasCollectorneeds a new name or not.